Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] Allow deploy of node-exporter dashboards when dependency disabled #4323

Merged
merged 2 commits into from
Mar 1, 2024
Merged

[kube-prometheus-stack] Allow deploy of node-exporter dashboards when dependency disabled #4323

merged 2 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. Allow deploy of node-exporter dashboards when dependency disabled 

    I've got node-exporter deployed seperately so it shows as an independent
app in Argo CD and so I can manage its upgrades independently, but since
its default dashboards are managed by the kube-prometheus-stack chart,
I don't get the node-exporter dashboards anymore.

This change allows forcing the deploy of the node-exporter dashboards,
as long as the other conditions for deploying Grafana dashboards are
met.

Signed-off-by: Andrew Titmuss <[email protected]>
    @iandrewt
    iandrewt committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2c82b78 View commit details
    Browse the repository at this point in the history

  2. Add newline to end of 03-non-default-values.yaml 

    Signed-off-by: Andrew Titmuss <[email protected]>
    @iandrewt
    iandrewt committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    bac0e17 View commit details
    Browse the repository at this point in the history