Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-prometheus-stack] Minify windows dashboards #3546

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[kube-prometheus-stack] Minify windows dashboards #3546

merged 1 commit into from
Jul 4, 2023

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Jul 3, 2023 •
edited
Loading

What this PR does / why we need it

Reduce the release secret size usage.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@jkroepke jkroepke changed the title Minify windows dashboards [kube-prometheus-stack] Minify windows dashboards Jul 3, 2023
@jkroepke jkroepke mentioned this pull request Jul 3, 2023
Closed
@jkroepke jkroepke force-pushed the minify-windows-dashboards branch 2 times, most recently from 52cb2e6 to 326e6a8 Compare July 3, 2023 21:17
@jkroepke
Copy link
Member Author

jkroepke commented Jul 3, 2023 

(.venv) jkr@joe-nb prometheus-community-helm-charts % kubectl get secrets sh.helm.release.v1.kube-prometheus-stack.v1 -o jsonpath='{.data.release}' | base64 -d > release
(.venv) jkr@joe-nb prometheus-community-helm-charts % ls -l release                                                                                                      
-rw-r--r--  1 jkr  staff  1025044 Jul  3 23:30 release

At least 1025044 bytes which is close to 1048576 bytes (limit)

@jkroepke jkroepke force-pushed the minify-windows-dashboards branch from 326e6a8 to 03b2ec4 Compare July 3, 2023 21:39
@jkroepke jkroepke mentioned this pull request Jul 3, 2023
Closed
@QuentinBisson QuentinBisson merged commit 4dd2e10 into prometheus-community:main Jul 4, 2023
@jkroepke jkroepke deleted the minify-windows-dashboards branch July 4, 2023 06:34
Matiasmct pushed a commit to giffgaff/prometheus-charts-backup that referenced this pull request Aug 25, 2023
@jkroepke @Matiasmct
[kube-prometheus-stack] Minify windows dashboards (prometheus-communi…
b302abe 
…ty#3546)

Signed-off-by: Jan-Otto Kröpke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuentinBisson QuentinBisson QuentinBisson approved these changes

@andrewgkew andrewgkew Awaiting requested review from andrewgkew andrewgkew is a code owner

@gianrubio gianrubio Awaiting requested review from gianrubio gianrubio is a code owner

@gkarthiks gkarthiks Awaiting requested review from gkarthiks gkarthiks is a code owner

@GMartinez-Sisti GMartinez-Sisti Awaiting requested review from GMartinez-Sisti GMartinez-Sisti is a code owner

@scottrigby scottrigby Awaiting requested review from scottrigby scottrigby is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kube-prometheus-stack] Chart version 47.2.0 broke compatibility (commit 990fcbc)
2 participants
@jkroepke @QuentinBisson