[kube-state-metrics] Allow adding volumeMounts and volumes in deployment #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gadi Sneh [email protected] Signed-off-by: gadisn <[email protected]>
Signed-off-by: gadisn <[email protected]>
Signed-off-by: gadisn <[email protected]>
|
@dotdc the 'lint code base' and 'lint-test' voters doesn't run for some reason. |
monotek
requested changes
Jul 22, 2022
Signed-off-by: gadisn <[email protected]>
monotek
previously approved these changes
Jul 24, 2022
|
@dotdc can you please review this? |
|
@mrueg , @tariq1890 - can you of you code owners please review? |
|
@dotdc, @mrueg, @tariq1890 - can any of you code owners review this PR? |
mrueg
reviewed
Aug 1, 2022
mrueg
reviewed
Aug 1, 2022
mrueg
reviewed
Aug 1, 2022
mrueg
reviewed
Aug 1, 2022
mrueg
reviewed
Aug 1, 2022
mrueg
reviewed
Aug 1, 2022
Signed-off-by: gadisn <[email protected]>
Signed-off-by: gadisn <[email protected]>
Signed-off-by: gadisn <[email protected]>
Signed-off-by: gadisn <[email protected]>
mrueg
approved these changes
Aug 2, 2022
|
Thanks for your contribution! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gadi Sneh [email protected]
What this PR does / why we need it:
Allow adding volumeMounts and volumes to the deployment.
For example, this can be used to mount a config map with definitions of metrics for CRD, see
--custom-resource-state-config-filehere.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])