fix(alertmanager): 🚑 resolve replicaCount comparision type issue #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
Signed-off-by: Prashant Shahi <[email protected]>
naseemkullah
approved these changes
Jul 5, 2022
stazdx
pushed a commit
to stazdx/helm-charts
that referenced
this pull request
Jul 6, 2022
…metheus-community#2231) * fix(alertmanager): 🚑 resolve replicaCount comparision type issue Signed-off-by: Prashant Shahi <[email protected]> * chore(release): 🔖 Bump up alertmanager to 0.18.3 Signed-off-by: Prashant Shahi <[email protected]> * fix(alertmanager): 🚑 backward compatiblity with older version of Helm Signed-off-by: Prashant Shahi <[email protected]> Signed-off-by: Staz <[email protected]>
ikarlashov
pushed a commit
to ikarlashov/helm-charts
that referenced
this pull request
Jul 8, 2022
…metheus-community#2231) * fix(alertmanager): 🚑 resolve replicaCount comparision type issue Signed-off-by: Prashant Shahi <[email protected]> * chore(release): 🔖 Bump up alertmanager to 0.18.3 Signed-off-by: Prashant Shahi <[email protected]> * fix(alertmanager): 🚑 backward compatiblity with older version of Helm Signed-off-by: Prashant Shahi <[email protected]> Signed-off-by: Evgen Karlashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Alertmanager HA setup with mutiple replicas is broken because of the issue tagged below. This PR resolves it.
Which issue this PR fixes
Checklist
Signed-off-by: Prashant Shahi [email protected]