[kube-state-metrics] Add selfMonitor.telemetryNodePort field to values #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexHill
force-pushed
the
telemetry_nodeport
branch
from
18c4b2e to
a911ef7
Compare
AlexHill
changed the title
|
Hi @AlexHill, I think it's ok to merge as is if you add the limitation in the comment block (see my review) |
Signed-off-by: Alex Hill <[email protected]>
Signed-off-by: Alex Hill <[email protected]>
AlexHill
force-pushed
the
telemetry_nodeport
branch
from
a911ef7 to
4227b7b
Compare
|
Hi @dotdc, thanks for the extremely quick response! Not sure what's going on but I can't see your review. In any case though I've added a comment now. |
|
My bad, the review was still pending. Anyway the comment is basically what I suggested. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a
selfMonitor.telemetryNodePortfield to values.yaml so that a NodePort for the telemetry endpoint can be specified whenservice.typeis set toNodePort.Special notes for your reviewer:
Tagging @tariq1890 @mrueg @dotdc as per the PR template comment.
There is a slight incongruence here in that if
selfMonitor.telemetryNodePortis specified butservice.typeis not set toNodePort, the deployment will fail. Options to fix, if desired:serviceNodePortif eitherservice.nodePortorselfMonitor.telemetryNodePortare specified(In the existing chart, the deployment will also fail if
services.nodePortis non-zero whileservices.typeis notNodePort- but that's a bit less surprising since the dependent fields are all under theservicestop-level key.)Checklist
[prometheus-couchdb-exporter])