-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search_query_current and indexing_index_current #485
Add search_query_current and indexing_index_current #485
Conversation
Signed-off-by: Loc Mai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These metric names are very confusing.
Signed-off-by: Loc Mai <[email protected]>
@SuperQ Big thanks for helping to review this! The Also updated the descriptions ^^ |
In Prometheus, we typically don't use direct 1:1 mappings for these kinds of things. The problem is a lot of systems (like Elastic) use statsd-style naming conventions, which are very hard to understand. We fix the naming in order to make metrics easier to use by the end user. |
Great point. But the indices.go looks like everything is 1:1 mapping. I think I will fix the new ones first then. |
Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Loc Mai <[email protected]>
3ce5483
to
963823e
Compare
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
537cb2d
to
71e4b91
Compare
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
Hi @sysadmind could you help me take a look at this PR? |
Signed-off-by: Loc Mai <[email protected]>
…nity#485) * Add search_query_current and indexing_index_current Signed-off-by: Loc Mai <[email protected]> * update descriptions Signed-off-by: Loc Mai <[email protected]> * Update collector/indices.go Co-authored-by: Ben Kochie <[email protected]> Signed-off-by: Loc Mai <[email protected]> * rename to current_indexed_docs Signed-off-by: Loc Mai <[email protected]> * update docs Signed-off-by: Loc Mai <[email protected]> * fix ordering Signed-off-by: Loc Mai <[email protected]> * fix ordering Signed-off-by: Loc Mai <[email protected]> * change back to index_current Signed-off-by: Loc Mai <[email protected]> Co-authored-by: Ben Kochie <[email protected]>
Signed-off-by: Loc Mai [email protected]
We are missing these 2 important metrics for our ES clusters: