-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: latest snapshot timestamp metric #318
feat: latest snapshot timestamp metric #318
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented (metric name). Looks good otherwise
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have the information that this is a timestamp in the metric name. It's a bit longer, but just _seconds
doesn't provide the information. I'm also fine with _ts_seconds
.
@zwopir done |
Great, thanks @caarlos0! I'm happy to see the explicit names, with tab completion in prometheus and grafana, abbreviations should be rather avoided. |
Me too 🙏 |
thanks again for the PR, @caarlos0 ! |
added a new metric that reports the timestamp of the latest
SUCCESS
/PARTIAL
snapshot.This should make it easier to alert things like
X time since the last snapshot
, even more helpful when you have some sort of repository rotation (e.g. each month has a new repository / s3 bucket, and we keep up to 2 old repositories there).with this metric the alert rule could be:
Thanks!