Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearch 2.0 #8

Closed
dylanmei opened this issue Nov 6, 2015 · 7 comments
Closed

ElasticSearch 2.0 #8

dylanmei opened this issue Nov 6, 2015 · 7 comments

Comments

@dylanmei
Copy link

dylanmei commented Nov 6, 2015

There are quite a few changes in ElasticSearch 2.0, one of which breaks the JSON deserialization.

What kind of plan would you take for supporting 1.x/2.x?
@ewr
Copy link
Collaborator

ewr commented Nov 6, 2015

That's a good question... I haven't had a chance to use 2.0 yet, because I've been waiting to see how support lands in the Chef cookbook.

Is the break from an element removal or something getting renamed / moved?

@dylanmei
Copy link
Author

dylanmei commented Nov 6, 2015

The break is because NodeStatsOSResponse.LoadAvg is a float64 rather than []float64.

@keis
Copy link

keis commented Jan 5, 2016

I looks like LoadAvg is never used so it should be fine to delete that and be compatible with both 1.x and 2.x. wdyt?

@ewr
Copy link
Collaborator

ewr commented Jan 5, 2016

I apologize for leaving this hanging. Let me pull down ES 2.x right now and take a look.

ewr added a commit that referenced this issue Jan 5, 2016
@ewr
Update stats structs to support ES 2.0; Add Thread Pool stats
9439462 
* Addresses #8
* Update README to note changes in ES 2.0
* Add stats for thread pool
@ewr
Copy link
Collaborator

ewr commented Jan 5, 2016

Ok, @keis / @dylanmei, give that a shot.

@dylanmei
Copy link
Author

dylanmei commented Jan 5, 2016

I've pointed this at a busy cluster and the metrics endpoint looks great. I've not checked the accuracy of the data -- I'll follow up with a different issue if there's anything unexpected for 2.0.

Thanks!

@dylanmei dylanmei closed this as completed Jan 5, 2016
@keis
Copy link

keis commented Jan 5, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dylanmei @keis @ewr