fix: correct quotation of flags in systemd config file #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Molecule testing results: PLAY RECAP *********************************************************************
almalinux-8 : ok=14 changed=0 unreachable=0 failed=0 skipped=12 rescued=0 ignored=0
centos-7 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
centos-stream-8 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
debian-10 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-11 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-9 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
fedora-30 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
ubuntu-18.04 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
INFO Idempotence completed successfully.
INFO Running default > side_effect
WARNING Skipping, side effect playbook not configured.
INFO Running default > verify
INFO Executing Testinfra tests found in /net/homes-beta/akingsto/git/prometheus.prometheus/roles/node_exporter/molecule/default/tests/...
============================= test session starts ==============================
platform linux -- Python 3.8.11, pytest-7.2.2, pluggy-1.0.0
rootdir: /net
plugins: testinfra-7.0.0
collected 48 items
molecule/default/tests/test_default.py ................................. [ 68%]
............... [100%]
============================= 48 passed in 17.06s ==============================
INFO Verifier completed successfully.PLAY RECAP *********************************************************************
almalinux-8 : ok=15 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
centos-7 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
centos-stream-8 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
debian-10 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-11 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-9 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
fedora-30 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
ubuntu-18.04 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
INFO Idempotence completed successfully.
INFO Running latest > side_effect
WARNING Skipping, side effect playbook not configured.
INFO Running latest > verify
INFO Executing Testinfra tests found in /net/homes-beta/akingsto/git/prometheus.prometheus/roles/node_exporter/molecule/latest/tests/...
============================= test session starts ==============================
platform linux -- Python 3.8.11, pytest-7.2.2, pluggy-1.0.0
rootdir: /net
plugins: testinfra-7.0.0
collected 32 items
molecule/latest/tests/test_alternative.py .............................. [ 93%]
.. [100%]PLAY RECAP *********************************************************************
almalinux-8 : ok=15 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
centos-7 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
centos-stream-8 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
debian-10 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-11 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
debian-9 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
fedora-30 : ok=13 changed=0 unreachable=0 failed=0 skipped=11 rescued=0 ignored=0
ubuntu-18.04 : ok=14 changed=0 unreachable=0 failed=0 skipped=10 rescued=0 ignored=0
INFO Idempotence completed successfully.
INFO Running latest > side_effect
WARNING Skipping, side effect playbook not configured.
INFO Running latest > verify
INFO Executing Testinfra tests found in /net/homes-beta/akingsto/git/prometheus.prometheus/roles/node_exporter/molecule/latest/tests/...
============================= test session starts ==============================
platform linux -- Python 3.8.11, pytest-7.2.2, pluggy-1.0.0
rootdir: /net
plugins: testinfra-7.0.0
collected 32 items
molecule/latest/tests/test_alternative.py .............................. [ 93%]
.. [100%]
============================== 32 passed in 7.16s ==============================
INFO Verifier completed successfully.
INFO Running latest > cleanup |
alkinks
force-pushed
the
node_exporter_systemd_template_fix
branch
from
e99e461 to
41f46f1
Compare
gardar
requested changes
Mar 16, 2023
Correct the quotation around the collector option flags and values in the node_exporter role systemd unit config file template so that regex values get parsed correctly. Refs: prometheus-community#68 Signed-off-by: Andrew Kingston <[email protected]>
Remove the quotation around the collector option flags and values in the node_exporter role systemd unit config file template so that regex values get parsed correctly. Refs: prometheus-community#68 Signed-off-by: Andrew Kingston <[email protected]>
Correct the quotation around the collector option flags and values in the node_exporter role systemd unit config file template so that regex values get parsed correctly. Refs: prometheus-community#68 Signed-off-by: Andrew Kingston <[email protected]>
alkinks
force-pushed
the
node_exporter_systemd_template_fix
branch
from
9e15b99 to
7437ac0
Compare
SuperQ
approved these changes
Mar 20, 2023
gardar
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the quotation around the collector option flags and values in the node_exporter role systemd unit config file template so that regex values get parsed correctly.
Refs: #68