-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warn but don't error out on unsupported http response on older ansible versions #507
base: main
Are you sure you want to change the base?
fix: warn but don't error out on unsupported http response on older ansible versions #507
Conversation
…nsible versions Signed-off-by: gardar <[email protected]>
What versions of python/ansible are unsupported? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through the comments, I guess this is fine for now.
Looks like it's ansible 2.9-2.13 btw. I was able to get a 302 response from gitlab by forcing http1.0 but unfortunately there doesn't seem to set the http version in the ansible module, I tried various headers to try and trick it to give a http1.0 response but no avail. |
…versions Signed-off-by: gardar <[email protected]>
Was able to fix the binary download itself by adding a fallback download task with the |
wow, it seems to works i wonder if we could verify checksum in an extra task during the rescue, just to keep integrity. |
Good point! I added a separate task for checksum verification, that enabled me to replace |
… ansible versions Signed-off-by: gardar <[email protected]>
1a395bc
to
6209b53
Compare
it's also needed when using older python with new-ish ansible. Thanks a lot for your patches. |
GitLab has recently started using 308 redirects for release assets, which causes compatibility issues with older versions of Ansible and Python. Our options for resolving this are limited, so the best solution for now is to allow the checksum download task to proceed with a warning. Unfortunately, this has the side effect of disabling checksum verification when the warning is triggered, but AFAIK it remains the only workable approach at this time.
See more here:
#475 (comment)
https://github.com/prometheus-community/ansible/actions/runs/11955696431/job/33328750307
cc @mgariepy