New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node_exporter): Fix ProtectHome for textfiles #184

Merged

SuperQ merged 1 commit into main from superq/node_textfile_home

Aug 22, 2023

Contributor

SuperQ commented Aug 4, 2023

Set the node_exporter ProtectHome=read-only when the textfile dir is in /home.

Fixes: #183

github-actions bot added bugfix roles/node_exporter labels

SuperQ requested a review from gardar

August 4, 2023 13:37

SuperQ added roles/node_exporter and removed roles/node_exporter labels

SuperQ force-pushed the superq/node_textfile_home branch from fb6345f to 7a7e76a Compare

August 4, 2023 15:02

github-actions bot added bugfix and removed bugfix labels

SuperQ force-pushed the superq/node_textfile_home branch from 7a7e76a to 597e7df Compare

August 4, 2023 15:13

github-actions bot added bugfix and removed bugfix labels

github-actions bot added bugfix and removed bugfix labels

SuperQ force-pushed the superq/node_textfile_home branch from ebb763f to b931ba4 Compare

August 16, 2023 15:53

github-actions bot added bugfix and removed bugfix labels

gardar reviewed

View reviewed changes

roles/node_exporter/templates/node_exporter.service.j2 Show resolved Hide resolved

github-actions bot added bugfix and removed bugfix labels

SuperQ requested a review from gardar

August 16, 2023 17:49

gardar force-pushed the superq/node_textfile_home branch from fa18448 to 59b3136 Compare

August 16, 2023 17:56

github-actions bot added bugfix and removed bugfix labels

gardar added roles/node_exporter and removed roles/node_exporter labels

gardar force-pushed the superq/node_textfile_home branch from 59b3136 to b941d90 Compare

August 16, 2023 18:13

github-actions bot added bugfix and removed bugfix labels

gardar force-pushed the superq/node_textfile_home branch from b941d90 to 55507f9 Compare

August 17, 2023 14:15

github-actions bot removed the bugfix label

github-actions bot added the bugfix label

gardar approved these changes

View reviewed changes

Contributor Author

SuperQ commented Aug 17, 2023

I have no idea what's causing the node_exporter alternative to fail. :(

Member

gardar commented Aug 18, 2023

I have no idea what's causing the node_exporter alternative to fail. :(

Found out that it was because the version number variable set for that scenario was set to version 1.0.0 which does not support --web.config.file
The way the version number variable was set caused it to be set only for the preparation task, which made the rest of the run unaware of the version being used.

Fixed in #197 by moving the molecule variables of all of the roles out of the playbooks and into the molecule configs so that they are accessible for every step of the molecule runs.
Also added logging on service status failures so that we can spot issues like this in the future without jumping through multiple hoops.

SuperQ force-pushed the superq/node_textfile_home branch from 55507f9 to 6659564 Compare

August 21, 2023 18:33

github-actions bot added bugfix and removed bugfix labels


          fix(node_exporter): Fix ProtectHome for textfiles

655afd6

Set the node_exporter `ProtectHome=read-only` when the textfile dir is
in `/home`.

Fixes: #183

Signed-off-by: SuperQ <[email protected]>

SuperQ force-pushed the superq/node_textfile_home branch from 6659564 to 655afd6 Compare

August 22, 2023 04:50

github-actions bot added bugfix and removed bugfix labels

SuperQ merged commit d7ad271 into main

SuperQ deleted the superq/node_textfile_home branch

August 22, 2023 12:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix roles/node_exporter