Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always create config file #113

Merged
merged 1 commit into from
May 24, 2023
Merged

fix: always create config file #113

merged 1 commit into from
May 24, 2023

Conversation

lpulley
Copy link
Contributor

@lpulley lpulley commented May 21, 2023

Currently, if basic_auth_users is removed and neither node_exporter_tls_server_config nor node_exporter_http_server_config is defined, the users remain defined.

This is probably not intended behavior, since removing all the basic auth users ought to disable basic auth.

@SuperQ SuperQ requested a review from gardar May 23, 2023 11:19
gardar
gardar approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
No idea what historical purpose those conditionals were supposed to serve, didn't find any clues from old commits.

@gardar gardar requested a review from SuperQ May 23, 2023 12:18
@gardar gardar merged commit 60bf4ba into prometheus-community:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardar gardar gardar approved these changes

@SuperQ SuperQ Awaiting requested review from SuperQ

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpulley @gardar