Implement flags to control retry delays #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to add the new external package, you will need to include the go modules and |
Of course. I somehow missed them in my |
Merged
|
You can now rebase against head with the removed vendor dir. |
Amend the client with two new flags, "--proxy.retry.initial-wait" and "--proxy.retry.max-wait", controlling how long to sleep after encountering a proxy poll failure (i.e. network timeout). An exponential, randomized backoff algorithm is used to prevent thundering herds. The initial wait is raised from 50ms to 1s. In practice waiting less than a second after a failure is rarely useful and prevents the server from being hammered with up to three requests in the second after a failure. Discussed in #82. Signed-off-by: Michael Hanselmann <[email protected]>
|
@SuperQ done, rebased on top of |
SuperQ
added a commit
that referenced
this pull request
Mar 28, 2024
* [FEATURE] Implement flags to control retry delays #83 * [ENHANCEMENT] Add scrape_id to error log #120 * [BUGFIX] /clients endpoint return application/json as Content-Type #121 Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Mar 29, 2024
* [FEATURE] Implement flags to control retry delays #83 * [ENHANCEMENT] Add scrape_id to error log #120 * [BUGFIX] /clients endpoint return application/json as Content-Type #121 Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new flags, "--proxy.retry.initial-wait" and
"--proxy.retry.max-wait", controlling how long to sleep after
encountering a proxy poll failure (i.e. network timeout). An
exponential, randomized backoff algorithm is used to prevent thundering
herds. Discussed in #82.