#177 Improve the dashboard otlp experience #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code has been updated to allow null values in environment variables and secrets dictionaries. It also refactors retrieval methods for both environmental and secret variables. Now, instead of directly calling methods on object instances, it utilizes a pair of the resource key and object as function parameters for greater flexibility. The dashboard injection logic has been updated to avoid duplication. The unit tests have been adapted to reflect these changes. Otlp service name is now included and set to the resource key from the manifest (same for docker compose) which should fix the display on the dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been updated to allow null values in environment variables and secrets dictionaries. It also refactors retrieval methods for both environmental and secret variables. Now, instead of directly calling methods on object instances, it utilizes a pair of the resource key and object as function parameters for greater flexibility. The dashboard injection logic has been updated to avoid duplication. The unit tests have been adapted to reflect these changes.
Otlp service name is now included and set to the resource key from the manifest (same for docker compose) which should fix the display on the dashboard.
Initial work for #177