-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to build docker images using custom Dockerfile #270
Comments
dombrovsky
added a commit
to dombrovsky/aspirational-manifests
that referenced
this issue
Dec 17, 2024
… Dockerfile instead of 'dotnet publish' (prom3theu5#270)
dombrovsky
added a commit
to dombrovsky/aspirational-manifests
that referenced
this issue
Dec 17, 2024
… Dockerfile instead of 'dotnet publish' (prom3theu5#270)
dombrovsky
added a commit
to dombrovsky/aspirational-manifests
that referenced
this issue
Dec 18, 2024
… Dockerfile instead of 'dotnet publish' (prom3theu5#270)
dombrovsky
added a commit
to dombrovsky/aspirational-manifests
that referenced
this issue
Dec 18, 2024
… Dockerfile instead of 'dotnet publish' (prom3theu5#270)
dombrovsky
added a commit
to dombrovsky/aspirational-manifests
that referenced
this issue
Dec 20, 2024
… Dockerfile instead of 'dotnet publish' (prom3theu5#270)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚀 Feature Description
As a developer, I'd like to use custom Dockerfile for building images for Aspire project resources.
🧰 Possible Solution
build
andgenerate
commands, that would instruct to use Dockerfile specified inDockerfileFile
msbuild property in csproj to build docker image, instead ofdotnet publish -t:PublishContainer
. If csproj doesn't have DockerfileFile property set, but Dockerfile file exist in project directory, use it. Otherwise fallback todotnet publish
way for this project resource.build
andgenerate
commands to provide docker build arguments.Considerations
Would be nice if custom Dockerfiles were supported by dotnet sdk. Depending on the final design for dotnet/sdk-container-builds#125, the solution for supporting custom Dockerfiles in Aspire8 may differ.
The text was updated successfully, but these errors were encountered: