Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to build docker images using custom Dockerfile #270

Open
2 tasks
dombrovsky opened this issue Dec 16, 2024 · 0 comments · May be fixed by #273
Open
2 tasks

Add a way to build docker images using custom Dockerfile #270

dombrovsky opened this issue Dec 16, 2024 · 0 comments · May be fixed by #273

Comments

@dombrovsky
Copy link

🚀 Feature Description

As a developer, I'd like to use custom Dockerfile for building images for Aspire project resources.

🧰 Possible Solution

  • Add optional parameter to build and generate commands, that would instruct to use Dockerfile specified in DockerfileFile msbuild property in csproj to build docker image, instead of dotnet publish -t:PublishContainer. If csproj doesn't have DockerfileFile property set, but Dockerfile file exist in project directory, use it. Otherwise fallback to dotnet publish way for this project resource.
  • Add optional parameter to build and generate commands to provide docker build arguments.

Considerations

Would be nice if custom Dockerfiles were supported by dotnet sdk. Depending on the final design for dotnet/sdk-container-builds#125, the solution for supporting custom Dockerfiles in Aspire8 may differ.

dombrovsky added a commit to dombrovsky/aspirational-manifests that referenced this issue Dec 17, 2024
dombrovsky added a commit to dombrovsky/aspirational-manifests that referenced this issue Dec 17, 2024
dombrovsky added a commit to dombrovsky/aspirational-manifests that referenced this issue Dec 18, 2024
dombrovsky added a commit to dombrovsky/aspirational-manifests that referenced this issue Dec 18, 2024
dombrovsky added a commit to dombrovsky/aspirational-manifests that referenced this issue Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant