Merge pull request #7 from prolificinteractive/chore/fix_presenter_de…

…legate [Chore] Fix Presenter Delegate
prolificinteractive · Jun 27, 2018 · eaa685c · eaa685c
2 parents b73707e + 8bc8774
commit eaa685c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/Velar.podspec b/Velar.podspec
@@ -8,7 +8,7 @@
 
 Pod::Spec.new do |s|
   s.name             = 'Velar'
-  s.version          = '0.1.6'
+  s.version          = '0.1.7'
   s.summary          = 'A custom alert view presenter.'
 
   s.description      = <<-DESC

diff --git a/Velar/Velar/Classes/VelarPresenter/VelarPresenter.swift b/Velar/Velar/Classes/VelarPresenter/VelarPresenter.swift
@@ -13,7 +13,7 @@ public final class VelarPresenter {
 
     // MARK: - Public Properties
 
-    public var delegate: VelarPresenterDelegate?
+    public weak var delegate: VelarPresenterDelegate?
 
     /// Dismiss label threshold.
     public var dismissThreshold: CGFloat = 100 {

diff --git a/Velar/Velar/Classes/VelarPresenter/VelarPresenterDelegate.swift b/Velar/Velar/Classes/VelarPresenter/VelarPresenterDelegate.swift
@@ -6,7 +6,7 @@
 //  Copyright © 2018 Jonathan Samudio. All rights reserved.
 //
 
-public protocol VelarPresenterDelegate {
+@objc public protocol VelarPresenterDelegate: class {
 
     /// Notifies delegate that velar presenter will present.
     func willPresent()
@@ -21,15 +21,3 @@ public protocol VelarPresenterDelegate {
     func didDismiss()
 
 }
-
-extension VelarPresenterDelegate {
-
-    func willPresent() { }
-
-    func willDismiss() { }
-
-    func didPresent() { }
-
-    func didDismiss() { }
-
-}