Swift 4.2 Update #26
Merged
Swift 4.2 Update #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
malinkas86
commented
Oct 22, 2018
malinkas86
commented
- Change the source to support Swift 4.2
* Change the source to support Swift 4.2
DannyVancura
requested changes
Oct 22, 2018
| podfile: Example/Podfile | ||
|
|
||
| before_install: | ||
| - gem install cocoapods --pre --no-rdoc --no-ri --no-document --quiet | ||
|
|
||
| script: | ||
| - set -o pipefail && xcodebuild test -project Marker/Marker.xcodeproj -scheme Marker-iOS -destination 'name=iPhone 7,OS=11.0' | xcpretty | ||
| - set -o pipefail && xcodebuild test -project Marker/Marker.xcodeproj -scheme Marker-iOS -destination 'name=iPhone 8,OS=12.0' | xcpretty |
There was a problem hiding this comment.
You can specify the latest version of the OS instead of a specific version number, that might help the maintainability.
There was a problem hiding this comment.
I couldn't find the syntax for it
There was a problem hiding this comment.
I couldn't find it either, never mind then, I remember using a syntax like OS=latest but I can't remember on top of my head.
DannyVancura
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.