Added factory functions for creating TextStyles based off existing values #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kdown_tag Markdown tag for underline (==)
htinlinn
reviewed
Jul 14, 2017
| XCTAssertEqual(capitalized, capitalized) | ||
| } | ||
|
|
||
| func testTextStyle_isNotEqual_whenCustom() { |
There was a problem hiding this comment.
This is kinda weird and I don't think there is really a good way to test equality for functions. Can you leave a comment noting this in the file where you are doing Equatable conformation?
| /// - Parameter color: Underline color. Defaults to textColor. | ||
| /// - Parameter style: Underline style. Defaults to single line. | ||
| /// - Returns: New TextStyle with underline. | ||
| public func underlined(color: UIColor? = nil, style: NSUnderlineStyle = .styleSingle) -> TextStyle { |
There was a problem hiding this comment.
Not sure if we should create individual functions for bold, italic and underlined... It might lead us down to a rabbit hole that we might not necessarily wanna go down.
| let strikethroughColorToUse = (newStrikethroughColor == nil) ? self.strikethroughColor : newStrikethroughColor! | ||
| let underlineStyleToUse = (newUnderlineStyle == nil) ? self.underlineStyle : newUnderlineStyle! | ||
| let underlineColorToUse = (newUnderlineColor == nil) ? self.underlineColor : newUnderlineColor! | ||
| let textTransformToUse = (newTextTransform == nil) ? self.textTransform : newTextTransform! |
There was a problem hiding this comment.
Would using ?? operator make these slightly nicer to read?
|
Closing this and reopening a new PR based on the latest master changes in #21... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextStyles based on existing values (e.g.textStyle.with(newTextColor:)TextStylewith new font sizeTextStylewith bold/italic as fontTextStyleandTextTransformto beEquatable