This repository has been archived by the owner on Mar 13, 2021. It is now read-only.
Add a builder for applications #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications are built using the Cloud Foundery CNB builder, cloudfoundry/cnb:bionic.
markfisher
reviewed
May 16, 2019
cf-cnb-clusterbuildtemplate.yaml
Outdated
| apiVersion: build.knative.dev/v1alpha1 | ||
| kind: ClusterBuildTemplate | ||
| metadata: | ||
| name: cf-cnb |
There was a problem hiding this comment.
I think we should we call this riff-application-cnb and then rename the current riff-cnb to riff-function-cnb.
There was a problem hiding this comment.
I'll rename cf-cnb-* to riff-app-cnb*. I don't want to change riff-cnb-* since that would be a breaking change with the current riff cli.
There was a problem hiding this comment.
bumped the version and renamed the clusterbuildtemplates to riff-application and riff-function
as gs://projectriff/riff-buildtemplate/riff-app-cnb-clusterbuildtemplate.yaml
scothis
force-pushed
the
application-builder
branch
from
6849ead to
c9364e9
Compare
Rename build templates to: - riff-application-clusterbuildtemplate - riff-function-clusterbuildtemplate
scothis
added a commit
to projectriff/system
that referenced
this pull request
May 20, 2019
nebhale
added
semver:minor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications are built using the Cloud Foundery CNB builder,
cloudfoundry/cnb:bionic.
This is the same structure as the function build template, without function specific args and an application builder image. It is used to build Application resources in riff-system.