Support v2 iceberg tables with gzip #8848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dimas-b
reviewed
Jun 17, 2024
There was a problem hiding this comment.
Thanks for the contribution @jgprogramming !
The fix LGTM in general, just a couple of minor comments.
.../service/impl/src/main/java/org/projectnessie/catalog/service/impl/ImportSnapshotWorker.java
Outdated
Show resolved
Hide resolved
|
instead of creating new test added two new cases to existing test:
Hope now it's ok, let me know what you think |
dimas-b
approved these changes
Jun 18, 2024
snazy
approved these changes
Jun 19, 2024
|
LGTM! Thanks for the contribution! |
rohanag12
added a commit
to rohanag12/nessie
that referenced
this pull request
Nov 22, 2024
Similar to projectnessie#8848, but for views.
rohanag12
added a commit
to rohanag12/nessie
that referenced
this pull request
Nov 22, 2024
Similar to projectnessie#8848, but for views.
rohanag12
added a commit
to rohanag12/nessie
that referenced
this pull request
Nov 22, 2024
Similar to projectnessie#8848, but for views.
snazy
pushed a commit
that referenced
this pull request
Nov 25, 2024
Similar to #8848, but for views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iceberg saves metadata with "gz.metadata.json" suffix when compressed with gzip for v2 tables and with "metadata.json.gz" for v1 tables. Current implementation recognizes only v1 gz tables and fails for v2.