Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated HttpClientBuilder #7803

Merged
merged 1 commit into from
May 23, 2024

Conversation

snazy
Copy link
Member

@snazy snazy commented Dec 5, 2023

HttpClientBuilder has been deprecated for removal for a while and it is now safe to remove it. The functionality has been fully migrated to NessieClientBuilder.

@ajantha-bhat
Copy link
Contributor

I still see it used in Trino FYI:

I know. We will remove in the next version bump time.

Trino side PR movement is slow. Still trinodb/trino#19524 is not merged.

@snazy snazy marked this pull request as draft December 5, 2023 11:13
@ajantha-bhat
Copy link
Contributor

@adutra: Raised a WIP PR at Trino side based on Iceberg snapshot release
trinodb/trino#20308

Once, Iceberg new version is released, I will rebase.

@snazy snazy force-pushed the remove-depr-http-client-builder branch from 6092fd0 to 8527ec6 Compare March 15, 2024 09:51
@snazy snazy force-pushed the remove-depr-http-client-builder branch from 8527ec6 to 7f93e4f Compare May 23, 2024 09:54
@snazy snazy marked this pull request as ready for review May 23, 2024 09:54
snazy added a commit to snazy/query-engine-integration-tests that referenced this pull request May 23, 2024
@snazy
Copy link
Member Author

snazy commented May 23, 2024

snazy added a commit to snazy/query-engine-integration-tests that referenced this pull request May 23, 2024
snazy added a commit to projectnessie/query-engine-integration-tests that referenced this pull request May 23, 2024
`HttpClientBuilder` has been deprecated for removal for a while and it is now safe to remove it. The functionality has been fully migrated to `NessieClientBuilder`.
@snazy snazy force-pushed the remove-depr-http-client-builder branch from 7f93e4f to cc6bba4 Compare May 23, 2024 15:02
@snazy snazy merged commit 1827e8d into projectnessie:main May 23, 2024
16 checks passed
@snazy snazy deleted the remove-depr-http-client-builder branch May 23, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants