-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated HttpClientBuilder
#7803
Merged
snazy
merged 1 commit into
projectnessie:main
from
snazy:remove-depr-http-client-builder
May 23, 2024
Merged
Remove deprecated HttpClientBuilder
#7803
snazy
merged 1 commit into
projectnessie:main
from
snazy:remove-depr-http-client-builder
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know. We will remove in the next version bump time. Trino side PR movement is slow. Still trinodb/trino#19524 is not merged. |
@adutra: Raised a WIP PR at Trino side based on Iceberg snapshot release Once, Iceberg new version is released, I will rebase. |
6092fd0
to
8527ec6
Compare
8527ec6
to
7f93e4f
Compare
snazy
added a commit
to snazy/query-engine-integration-tests
that referenced
this pull request
May 23, 2024
snazy
added a commit
to snazy/query-engine-integration-tests
that referenced
this pull request
May 23, 2024
snazy
added a commit
to projectnessie/query-engine-integration-tests
that referenced
this pull request
May 23, 2024
`HttpClientBuilder` has been deprecated for removal for a while and it is now safe to remove it. The functionality has been fully migrated to `NessieClientBuilder`.
7f93e4f
to
cc6bba4
Compare
dimas-b
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpClientBuilder
has been deprecated for removal for a while and it is now safe to remove it. The functionality has been fully migrated toNessieClientBuilder
.