Cleanup V2 MergeResponse #6747
Merged
Cleanup V2 MergeResponse #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that all non-V2 attributes in `MergeResponse` (those that are present for V1, but deprecated) are properly annotated with `@JsonView(Views.V1.class)`. On top of the already deprecated attributes, `MergeResponse.ContentKeyDetails.getConflictType()` is deprecated and V1-only now as well. It already has a better replacement with `MergeResponse.getConflictType.getConflict()`. The corresponding enum is also deprecated now. Fixes projectnessie#5689
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all non-V2 attributes in
MergeResponse(those that are present for V1, but deprecated) are properly annotated with@JsonView(Views.V1.class).On top of the already deprecated attributes,
MergeResponse.ContentKeyDetails.getConflictType()is deprecated and V1-only now as well. It already has a better replacement withMergeResponse.getConflictType.getConflict(). The corresponding enum is also deprecated now.Fixes #5689