Reenable JVM monitoring in native images #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change effectively reverts projectnessie#5903 (projectnessie#5900), since oracle/graal#5303 is marked resolved for GraalVM 22.3.1, which is not also used for our native image builds via `quay.io/quarkus/[email protected]` pointing to `22.3.1`.
|
/cc @julwin |
dimas-b
approved these changes
Feb 7, 2023
Codecov ReportBase: 77.88% // Head: 77.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6052 +/- ##
=========================================
Coverage 77.88% 77.88%
Complexity 3758 3758
=========================================
Files 555 555
Lines 17094 17094
Branches 1703 1703
=========================================
Hits 13313 13313
Misses 3161 3161
Partials 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change effectively reverts #5903 (#5900), since oracle/graal#5303 is marked resolved for GraalVM 22.3.1, which is not also used for our native image builds via
quay.io/quarkus/[email protected]pointing to22.3.1.