Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bundled bootstrap.min.css #145

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Conversation

tamarinkeisari
Copy link
Contributor

@tamarinkeisari tamarinkeisari commented Jul 3, 2024

Import Bootstrap CSS Locally

Description: This pull request modifies the project to import the Bootstrap CSS file directly from the node_modules directory, replacing the current dependency on the CDN link.

Summary of Changes
This update addresses the feature request to enhance the project's ability to function in isolated environments without internet access by importing Bootstrap CSS locally. The following changes have been made:

  • Remove CDN Link
  • Local Bootstrap Import:
    Added an import statement for bootstrap.min.css in src/index.tsx.

we test it locally in it seems to run fine

Related issue:
#144

@CLAassistant
Copy link

CLAassistant commented Jul 3, 2024

CLA assistant check
All committers have signed the CLA.

@snazy
Copy link
Member

snazy commented Jul 3, 2024

@tamarinkeisari thanks for the contribution!
Looks like CI (build) is not happy with your change, can you take a look?

@tamarinkeisari
Copy link
Contributor Author

Hi, @snazy
The ESlint is configured with the import/no-internal-modules option which prevents importing the bootstrap min css from the node modules. Should we add an eslint ignore on the import?

@snazy
Copy link
Member

snazy commented Jul 8, 2024

The ESlint is configured with the import/no-internal-modules option which prevents importing the bootstrap min css from the node modules. Should we add an eslint ignore on the import?

Works for me. But only for that file.

@tamarinkeisari
Copy link
Contributor Author

I disabled the eslint rule for that import line like we discussed

@snazy
Copy link
Member

snazy commented Jul 8, 2024

Can you also fix the 2nd build issue?

@tamarinkeisari
Copy link
Contributor Author

Hi, after I run npm run lint the build works, but the linting changes a lot of files in the project that are not related to the PR.
Do you want me to upload these unrelated fixes?

@snazy
Copy link
Member

snazy commented Jul 8, 2024

@tamarinkeisari only the one that lets CI fail

@tamarinkeisari
Copy link
Contributor Author

I uploaded the fix, please let me know if there is anything else to do?

@snazy
Copy link
Member

snazy commented Jul 8, 2024

Looks like you haven't signed the CLA yet.

@tamarinkeisari
Copy link
Contributor Author

Signed :)

Copy link
Member

@snazy snazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snazy snazy changed the title fix: deleted cdn link from index.html and added import for bootstrap min.css in index.tsx Use bundled bootstrap.min.css Jul 10, 2024
@snazy snazy merged commit b2da1b8 into projectnessie:main Jul 10, 2024
2 checks passed
@snazy
Copy link
Member

snazy commented Jul 10, 2024

@tamarinkeisari sorry, we not be able include this change in Nessie yet. There's something odd there.

I'm not sure whether it's your change or something else. The UI looks different.

Previous nessie-ui release 0.63.6:
image

0.64.0:
image

@snazy
Copy link
Member

snazy commented Jul 10, 2024

Can confirm - it's from your change.

nessie-ui from commit 4d132d9 looks fine:
image

snazy added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants