-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use bundled bootstrap.min.css
#145
Conversation
…min.css in index.tsx
@tamarinkeisari thanks for the contribution! |
Hi, @snazy |
Works for me. But only for that file. |
…otstrap css import
I disabled the eslint rule for that import line like we discussed |
Can you also fix the 2nd build issue? |
Hi, after I run npm run lint the build works, but the linting changes a lot of files in the project that are not related to the PR. |
@tamarinkeisari only the one that lets CI fail |
I uploaded the fix, please let me know if there is anything else to do? |
Looks like you haven't signed the CLA yet. |
Signed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bootstrap.min.css
@tamarinkeisari sorry, we not be able include this change in Nessie yet. There's something odd there. I'm not sure whether it's your change or something else. The UI looks different. |
Can confirm - it's from your change. nessie-ui from commit 4d132d9 looks fine: |
Import Bootstrap CSS Locally
Description: This pull request modifies the project to import the Bootstrap CSS file directly from the node_modules directory, replacing the current dependency on the CDN link.
Summary of Changes
This update addresses the feature request to enhance the project's ability to function in isolated environments without internet access by importing Bootstrap CSS locally. The following changes have been made:
Added an import statement for bootstrap.min.css in src/index.tsx.
we test it locally in it seems to run fine
Related issue:
#144