Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples in external repo #735

Closed

Conversation

SebastianoF
Copy link
Contributor

@SebastianoF SebastianoF commented Sep 25, 2019

Related to #134 .

The tests related to examples are integration tests leveraging on the examples, or examples tests itself. Should be moved under the mesa-examples repository. Skipped in the PR for now.

Thanks!
S

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #735 into master will decrease coverage by 9.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   84.66%   75.53%   -9.14%     
==========================================
  Files          17       18       +1     
  Lines        1024     1034      +10     
  Branches      168      168              
==========================================
- Hits          867      781      -86     
- Misses        126      218      +92     
- Partials       31       35       +4
Impacted Files Coverage Δ
mesa/batchrunner.py 74.3% <ø> (+0.55%) ⬆️
...esa/visualization/modules/BarChartVisualization.py 18.91% <0%> (-70.28%) ⬇️
mesa/visualization/modules/ChartVisualization.py 28% <0%> (-64%) ⬇️
...esa/visualization/modules/PieChartVisualization.py 28% <0%> (-64%) ⬇️
mesa/visualization/modules/HexGridVisualization.py 35.71% <0%> (-60.72%) ⬇️
mesa/visualization/modules/NetworkVisualization.py 37.5% <0%> (-50%) ⬇️
mesa/datacollection.py 89.87% <0%> (-7.6%) ⬇️
mesa/visualization/ModularVisualization.py 73.1% <0%> (-4.21%) ⬇️
mesa/space.py 92.88% <0%> (-0.68%) ⬇️
mesa/agent.py 90% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc17ca...23aaaab. Read the comment docs.

@SebastianoF
Copy link
Contributor Author

Planning to recover the percentage lost with this PR in the week end!

Base automatically changed from master to main March 14, 2021 05:26
@rht
Copy link
Contributor

rht commented Mar 22, 2022

There is a huge merge conflict in this PR. This PR should better be redone right after when the decision to move the examples to an external repo is finalized.

@SebastianoF
Copy link
Contributor Author

Yep thanks, in the meantime I changed job twice and not really into mesa any longer. Closing it, and I am not likely to re-do the PR after the decision will be finalised.

@SebastianoF SebastianoF deleted the EXAMPLES-in-external-repo branch April 14, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants