-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3D rendering for CanvasGrids #402
Conversation
As I catch up on things, I just want to say that your contributions have brought me such joy! <3 <3 <3 |
RE: "I want to add this for the Flocker's example (as it seems like the more applicable example), but I started with WolfSheep."
|
RE: Testing going down... can you update your branch with what it is Master, so when I look at test coverage, I am only looking at your changes? |
Sure I'll do a rebase and push it out. |
0891ab5
to
6cf70f0
Compare
Let me know when you are done & I will look again. |
@jackiekazil I'll get back to this today or tomorrow. Been at IEEE VIS all week, haven't had a moment to spare! |
6cf70f0
to
b27e01d
Compare
@jackiekazil Okay, I'm finally looking at this again. Coverage went down because of changes to The reason it is needed for the Also, I did not include the WolfSheep 3D visualization files, but the 3D Flocker example seems to work on my machine. If folks have issues, then we should revisit it. |
Discussion during today's meeting....
Closing for now... Taylor will resubmit when he is ready. No rush on this. Let's make sure we have a good use case implemented for this. |
This PR opens up opportunities for rendering out grids in 3D. For simplicity, it sub-classes the
CanvasGridVisualization
and adds frontend components using ThreeJS to render out cubes over a plane.I mainly want to have this here as both a discussion topic as well as solicit suggestions for additions and revisions. I will likely add to this PR with a couple bug fixes, but this is a starter.
I want to add this for the Flocker's example (as it seems like the more applicable example), but I started with WolfSheep.