Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve order of script/stylesheet includes #47

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Jan 3, 2024

Changes the collecting of an element's includes to use dicts to preserve the order specified by the element and (and retain the prevention duplicates). As noted in #24, this is needed when a module has dependencies that rely on others being loaded first.

Alternatively, using lists may make it slightly more clear what is happening but would require the additional step of removing duplicates


resolves #24

@rht rht merged commit 7b5a7b7 into projectmesa:main Jan 7, 2024
8 checks passed
@rht
Copy link
Contributor

rht commented Jan 7, 2024

Thank you for fixing the long-standing bug!

@sgfost
Copy link
Contributor Author

sgfost commented Jan 10, 2024

Sure thing, thanks for your work on mesa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set() for local and package includes in ModularVisualization.py causes nondeterministic loading order.
2 participants