-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ModularServer from Mesa #109
use ModularServer from Mesa #109
Conversation
Codecov ReportBase: 79.90% // Head: 78.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 79.90% 78.51% -1.39%
==========================================
Files 7 7
Lines 622 619 -3
Branches 108 99 -9
==========================================
- Hits 497 486 -11
- Misses 108 116 +8
Partials 17 17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -1,10 +1,10 @@ | |||
import mesa | |||
from mesa.visualization.ModularVisualization import ModularServer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for import. Should have used the new namespace in the code below with mesa.visualization.ModularServer
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Totally forgot that. I've updated all examples to use simple namespace from Mesa in a separate commit.
Perhaps a similar simple namespace should be implemented for Mesa-Geo too, to be consistent with Mesa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, agreed for Mesa-Geo simple namespace.
9d563bd
to
5c92564
Compare
mesa_geo.visualization.ModularVisualization.ModularServer
class to show a deprecation warning.