Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ModularServer from Mesa #109

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

wang-boyu
Copy link
Member

  • Implements Use ModularServer from Mesa #76.
  • Add a mesa_geo.visualization.ModularVisualization.ModularServer class to show a deprecation warning.
  • Update the examples accordingly.

@wang-boyu wang-boyu added this to the v0.4.0 milestone Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 79.90% // Head: 78.51% // Decreases project coverage by -1.38% ⚠️

Coverage data is based on head (5c92564) compared to base (bf7a3bd).
Patch coverage: 75.75% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   79.90%   78.51%   -1.39%     
==========================================
  Files           7        7              
  Lines         622      619       -3     
  Branches      108       99       -9     
==========================================
- Hits          497      486      -11     
- Misses        108      116       +8     
  Partials       17       17              
Impacted Files Coverage Δ
mesa_geo/visualization/ModularVisualization.py 0.00% <0.00%> (ø)
mesa_geo/geospace.py 85.31% <100.00%> (-0.09%) ⬇️
mesa_geo/raster_layers.py 73.92% <100.00%> (ø)
mesa_geo/visualization/modules/MapVisualization.py 89.09% <100.00%> (-0.20%) ⬇️
mesa_geo/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -1,10 +1,10 @@
import mesa
from mesa.visualization.ModularVisualization import ModularServer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for import. Should have used the new namespace in the code below with mesa.visualization.ModularServer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Totally forgot that. I've updated all examples to use simple namespace from Mesa in a separate commit.

Perhaps a similar simple namespace should be implemented for Mesa-Geo too, to be consistent with Mesa.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed for Mesa-Geo simple namespace.

@wang-boyu wang-boyu force-pushed the feat/use-modular-server-from-mesa branch from 9d563bd to 5c92564 Compare October 11, 2022 00:21
@rht rht merged commit 4f330fb into projectmesa:main Oct 11, 2022
@rht rht mentioned this pull request Oct 11, 2022
@wang-boyu wang-boyu deleted the feat/use-modular-server-from-mesa branch October 11, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants