hamster: explicitly set application ID and prgname on startup

[mwilck]

Under wayland, passing application_id to Gtk.Application.Init()
is not sufficient to set the application ID and program name
so that the shell sees it. See e.g.

https://www.programcreek.com/python/example/87806/gi.repository.GLib.set_prgname
https://gitlab.gnome.org/GNOME/gtk/issues/653
https://gitlab.gnome.org/GNOME/gtk/commit/72ec8963d7df0e39f688838e42445c869e4875c9

This should fix #541.

[bochecha]

Are both of those necessary?

[mwilck]

No, not to fix the icon name. But I think this way we're on the safe side.

[ederag]

Interesting, and thanks for the links ! Need to test and read.

[ederag]

That yields both under wayland and gnome the left image.

which is exactly what hamster --name=org.gnome.Hamster.GUI gave;
and that I found ugly at first (too much information for a casual user).
Right image is the result of c3ae7b1

Your link to commit eventually lead me to
https://developer.gnome.org/gtk4/stable/gtk-migrating-3-to-4.html#id-1.6.4.3.13

In GTK 4 we want the application's GApplication 'application-id' (and therefore the D-Bus name),
the desktop file basename and Wayland's xdg-shell app_id to match.
In order to achieve this with GTK 3.x call g_set_prgname()
with the same application ID you passed to GtkApplication.
Rename your desktop files to match the application ID if needed.

The call to g_set_prgname() can be removed once you fully migrated to GTK 4.

So the set_application_name is redundant with app_id=, let's remove it,
and just keep set_prgname.

Let's just use the application_id property,
that clarifies the changes to be made then (a single line).

[mwilck]

Wow, thanks for sorting this out. Not really obvious for the casual programmer, is it?

[mwilck]

Fine with me, please merge at your discretion.

[ederag]

@mwilck, @bochecha Thanks for the confirmations (I take the thumb up as one).
And indeed, it's not obvious; nice team work !