Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Install the desktop file #532

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

bochecha
Copy link
Contributor

Not having this makes it a bit harder to launch the app. 😜

Not having this makes it a bit harder to launch the app.
@ederag ederag merged commit 862e48b into projecthamster:master Jan 31, 2020
@ederag
Copy link
Collaborator

ederag commented Jan 31, 2020

Indeed, thanks !

Side note: hamster.desktop (and hamster-windows-service) should be improved to comply with
https://wiki.gnome.org/HowDoI/DBusApplicationLaunching
Would you by chance also know how to do all this cleanly ?

@bochecha bochecha deleted the desktop-install branch January 31, 2020 17:04
@bochecha
Copy link
Contributor Author

Would you by chance also know how to do all this cleanly ?

I'm not sure. The usual approach is to use GApplication (through GtkApplication) and its --gapplication-service command-line option so that the app is started as a background service. Then there are a few trivial things to do with the desktop file, and you're done.

However in the case of Hamster, the DBus service seems to be completely separated from the app if I understood correctly? (they are different processes, different executables, …)

I don't know how to handle such a case. 😕

@ederag
Copy link
Collaborator

ederag commented Jan 31, 2020

The usual approach is to use GApplication (through GtkApplication) and its --gapplication-service command-line option so that the app is started as a background service. Then there are a few trivial things to do with the desktop file, and you're done.

Thanks for the confirmation, that's exactly the goal.

The DBus service seems to be completely separated from the app if I understood correctly?

Opened #533 to discuss this further.

Reading hamster-cli.py again, it is work in progress,
the structure is unclear for a new reader right now.
I'll try this week-end and call for help or review.

@ederag
Copy link
Collaborator

ederag commented Feb 2, 2020

@bochecha #536 made progress, but now it's stuck.
Help would be much appreciated, if you have time this week.
Please do tell on #533 if you start working on it, to avoid duplicating efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants