Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid unparseable facts - take2 #481

Merged
merged 1 commit into from
Nov 23, 2019

Conversation

ederag
Copy link
Collaborator

@ederag ederag commented Nov 19, 2019

Make the save button active only if the fact entered can be parsed (and thus edited) from the cmdline.
This hopefully answers #461 (comment) favorably, while waiting for #465.

[This is the last commit of #476, which will be closed]

@GeraldJansen
Copy link
Contributor

LGTM

@ederag ederag mentioned this pull request Nov 23, 2019
@ederag ederag merged commit 556d31a into projecthamster:master Nov 23, 2019
@ederag ederag deleted the forbid-unparseable-take2 branch November 23, 2019 15:20
@mwilck mwilck mentioned this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants