Fix command line export #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now Fact.delta is calculated upon access. This fixes durations that were not updated in the overview for the running activity.
No longer used in hamster. And could lead to ValueError: I/O operation on closed file
Fix TSV export
return end_time - self.start_time
TypeError: unsupported operand type(s) for -: 'str' and 'str'
setAttribute expects strings, otherwise
File "/usr/lib64/python3.6/xml/dom/minidom.py", line 305, in _write_data
data = data.replace("&", "&").replace("<", "<"). \
TypeError: an integer is required (got type str)
This was referenced Jan 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit (905d83b) was already prepared and used in export.
The next two commits (8b166c4 and 45c5e87) did fix issue #373.
This removes the
ReportWriter.exportfunction inreports.pythat was no longer used in hamster.
Since it lead to
ValueError: I/O operation on closed fileanyway,it was removed altogether.