-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.0.2? #588
Comments
I have nothing against it. Could you send a PR? |
Sorry, but I'm not comfortable with the release process. I'd prefer to leave the release management to the maintainers. |
This how it works - someone creates a PR, and the maintainers will discuss and possibly merge it. You may recall that nobody can push directly to the master repo any more. But if you'd rather wait for someone else to create the PR, fine with me. |
Seems like creating a PR for a release is a good job for the maintainers, actually, not so much a "random" contributor would do. I haven't looked at what's involved in a release yet, probably changelog, maybe bumping a version somewhere and once it's merged, tag the resulting commit (I think we can push tags directly, though you can probably also create them through the github releases tab as well). I can have a look later, gotta run now. |
Checklist: https://github.com/projecthamster/hamster/projects/1#card-27399663 |
Probably good to include a fix for #590 as well (which is not merged yet, though). |
Yay ! Last commit Mar 14, we are Apr 29. Let's delay some more ! 😄 |
I'm not entirely sure what you mean here. I suspect you're being cynical? If you have alternative proposals, please state them plainly with arguments, so we can have constructive discussions. |
Not much more plain, but well. I can probably guess what you mean. My original thought was that #590 is a very similar problem (with offsets in dates), so it would be good to include that. However, it seems the fix is a little bit more involved, so maybe releasing what we have now might indeed be better than trying to fix #590 first (e.g. rather than spending time fixing that, better spend some time figuring out the release process first). I'll have a go at preparing a release, probably though a PR, using the checklist @ederag linked. |
Thanks and congratulations on the first release made by the new maintainers. |
It would be good to release a v3.0.2 including bug fix #580.
The text was updated successfully, but these errors were encountered: