Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove call to deprecated bind_textdomain_codeset gettext function
This function was deprecated and eventually removed in Python3.11 (see changelog at https://docs.python.org/3/whatsnew/3.11.html) > Removed the deprecated gettext functions lgettext(), ldgettext(), > lngettext() and ldngettext(). Also removed the bind_textdomain_codeset() > function, the NullTranslations.output_charset() and > NullTranslations.set_output_charset() methods, and the codeset parameter > of translation() and install(), since they are only used for the > l*gettext() functions. (Contributed by Dong-hee Na and Serhiy Storchaka > in bpo-44235.)
- Loading branch information
b155ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today's (2023.05.15) Arch Linux upgrade made Hamster don't start. Commenting this line out helped.
Looks like this patch should be implemented wrapped in condition of detection of Python runtime version.
b155ad5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it? In the PR about this, I think we decided to drop the line entirely, because it has no function in python3 at all (and we do not supported python2 anymore). It's just that this is fixed in git master, but not included in a release yet (working on that...).