add new types of node lock #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuodenumL
force-pushed
the
feature/lock
branch
2 times, most recently
from
79da76e to
3f0e424
Compare
CMGS
reviewed
Mar 3, 2022
cluster/calcium/remap.go
Outdated
| type remapEntry struct { | ||
| ctx context.Context | ||
| nodeName string | ||
| logger log.Fields |
CMGS
reviewed
Mar 3, 2022
cluster/calcium/remap.go
Outdated
| // watch remap queue | ||
| func (c *Calcium) watchRemapChan() { | ||
| for { | ||
| if entry, ok := <-c.remapChan; ok { |
There was a problem hiding this comment.
其实我的问题在于，你这样相当于是单机 remap，多 core 咋办
There was a problem hiding this comment.
我也发现这个问题了，但是还没来得及改…
应该是要新增一种类型的锁，专门给remap用
|
所以就按照最开始的讨论引入 node operation lock 了事 |
|
现在把node lock分成了两种，一种node resource lock，一种node operation lock（主要给remap用）。 |
CMGS
force-pushed
the
master
branch
3 times, most recently
from
06977aa to
837bec8
Compare
CMGS
reviewed
Mar 9, 2022
cluster/calcium/lock.go
Outdated
| nf := types.NodeFilter{ | ||
| Includes: []string{nodename}, | ||
| All: true, | ||
| } | ||
| return c.withNodesLocked(ctx, nf, func(ctx context.Context, nodes map[string]*types.Node) error { | ||
| return c.withNodesResourceLocked(ctx, nf, func(ctx context.Context, nodes map[string]*types.Node) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前remap要拿一个node的锁，而且remap流程还挺长的，一直拿着锁会卡住其它部署请求。而remap的锁只是为了保证不会有多个请求同时去remap，其实可以用chan来代替锁的功能。
修改之后会有一个goroutine来循环监听remapChan，调用方只需要异步将node name塞进remapChan即可，大大节约了持有锁的时间。
为了尽量防止脏数据的问题，remap里的实现也稍微改了下，每次都要重新获取node的资源信息。