Overhaul wal for create workload #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
测试的时候发现有比较大的疏漏, 挑出其中一个来说, workload 可能的状态表:
仔细分析代码可以发现上面五种状态都有可能产生, 完全取决于 crash 的时机; |
|
1 怎么出来的。。。 |
回滚步骤里, 会先删数据, 再删实例, 如果在中间 crash 了就是状态 1 了. 不过我想到了一个简单点的做法. |
jschwinger233
force-pushed
the
zc/create-wal
branch
from
d6da4e9 to
1f31358
Compare
|
针对 create WAL 的问题:
|
jschwinger233
changed the title
CMGS
reviewed
Jan 26, 2022
cluster/calcium/create.go
Outdated
| @@ -55,14 +55,33 @@ func (c *Calcium) doCreateWorkloads(ctx context.Context, opts *types.DeployOptio | |||
| defer func() { | |||
| cctx, cancel := context.WithTimeout(utils.InheritTracingInfo(ctx, context.TODO()), c.config.GlobalTimeout) | |||
| for nodename := range deployMap { | |||
| if e := c.store.DeleteProcessing(cctx, opts.GetProcessing(nodename)); e != nil { | |||
| processing := opts.GetProcessing(nodename) | |||
| if e := c.store.DeleteProcessing(cctx, processing); e != nil { | |||
CMGS
reviewed
Jan 26, 2022
engine/engine.go
Outdated
| @@ -41,7 +41,7 @@ type API interface { | |||
| VirtualizationCopyTo(ctx context.Context, ID, target string, content []byte, uid, gid int, mode int64) error | |||
| VirtualizationStart(ctx context.Context, ID string) error | |||
| VirtualizationStop(ctx context.Context, ID string, gracefulTimeout time.Duration) error | |||
| VirtualizationRemove(ctx context.Context, ID string, volumes, force bool) error | |||
| VirtualizationRemove(ctx context.Context, ID string, volumes, force bool) (int, error) | |||
jschwinger233
changed the title
jschwinger233
changed the title
|
LGTM |
anrs
reviewed
Jan 28, 2022
| var processingCommits map[string]wal.Commit | ||
| defer func() { | ||
| for nodename := range processingCommits { | ||
| if err := processingCommits[nodename](); err != nil { |
There was a problem hiding this comment.
can we make sure the processingCommits[nodename]is callable or nil while c.wal.Log returns an error?
jschwinger233
force-pushed
the
zc/create-wal
branch
from
43b0bb2 to
cd21b45
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.