Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAL can wait and recycle lambdas #531

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Jan 6, 2022

WAL for lambda 焦距的中间状态是 "创建完成后, 运行完毕前". 这是因为创建流程有 WAL for create 来保护, 所以没有必要关心创建.

  1. 把 walLog 的位置从 CreateWorkload 之前移动到了 CreateWorkload 之后, 除了因为创建流程有 WAL for create 来保护, 另一方面是 createWorkload 之后可以拿到 workloadID, 因此可以更加精细地管理, 而不必像之前只能通过 app+entry+label 查询, 可能会误删.
  2. WAL for lambda handler 里就是去 Wait 然后 Remove.

@jschwinger233 jschwinger233 requested a review from anrs January 6, 2022 08:25
@jschwinger233 jschwinger233 force-pushed the zc/wal branch 2 times, most recently from 58d27f9 to 9a8d89e Compare January 7, 2022 08:04
@jschwinger233 jschwinger233 changed the title [WIP] wal can wait and recycle lambdas WAL can wait and recycle lambdas Jan 7, 2022
@anrs
Copy link
Contributor

anrs commented Jan 17, 2022

LGTM

@CMGS CMGS merged commit 617d556 into projecteru2:master Jan 17, 2022
DuodenumL pushed a commit to DuodenumL/core that referenced this pull request Jan 21, 2022
* wal can wait and recycle lambdas

* fix test and lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants