migrate selfmon to eru-core #528
Conversation
DuodenumL
force-pushed
the
feature/selfmon
branch
2 times, most recently
from
1100709 to
1b77385
Compare
|
怎么上线? 先上 core, 然后把旧的 selfmon 都关掉, 然后再上 agent, 就算上 core 和关闭 selfmon agent 之间有一点小间隔应该也没事. |
这个顺序应该没问题 |
DuodenumL
force-pushed
the
feature/selfmon
branch
2 times, most recently
from
8734c78 to
c3dc08c
Compare
store/etcdv3/node.go
Outdated
| log.Errorf(ctx, "[doGetNodes] failed to get node status of %v, err: %v", node.Name, err) | ||
| } | ||
| node.Available = err == nil | ||
|
|
||
| if (!node.IsDown() || all) && utils.FilterWorkload(node.Labels, labels) { |
There was a problem hiding this comment.
IsDown 的名字要不改改, 里面的判断其实包含了 bypass, 所以返回 true 的时候并不一定是 down
store/etcdv3/node.go
Outdated
| for _, n := range nodes { | ||
| node := n | ||
| pool.Go(ctx, func() { | ||
| _, err := m.GetNodeStatus(ctx, node.Name) |
DuodenumL
force-pushed
the
feature/selfmon
branch
from
c3dc08c to
1ab646d
Compare
cluster/calcium/execute.go
Outdated
| logger.Errorf(ctx, "[ExecuteWorkload] Failed to get workload: %+v", err) | ||
| return | ||
| } | ||
| if workload.Engine == nil { |
There was a problem hiding this comment.
这个实在是太危险了, 过两个月恐怕自己都要忘记, 你想做成 Engine() error 这种 getter 吗, 然后把 engine 改为 internal member. 要是不想改就这样也行.
There was a problem hiding this comment.
暂时先放成这样吧，先把这个功能上上去。要做成getter这种需要比较大的改动，因为node里没有store，得想办法把创建engine这个事儿挪到外面才行。
目前的想法是getNode的时候把ca / cert / key一并取了，应该是可以实现的。
There was a problem hiding this comment.
我说的是
func (w *Workload) Engine() (engine.API, error) {
if w.engine == nil { return Err }
return w.engine
}There was a problem hiding this comment.
比如 calcium/helper.go 里的 node.Engine 就忘了做判断, 我看了一下那里的调用栈, 完全是可能产生 panic 的, 用 getter 就可以杜绝.
DuodenumL
force-pushed
the
feature/selfmon
branch
from
1ab646d to
83e22c0
Compare
|
41 files changed…… |
DuodenumL
force-pushed
the
feature/selfmon
branch
from
83e22c0 to
dc43c96
Compare
|
自测的时候发现了一些问题, 经过反复讨论决定继续改善一下 cache, 把 engine cache 封装成一个自检活的 client 连接池, 这样可以无脑取 cache 来用而不必再检活. |
DuodenumL
force-pushed
the
feature/selfmon
branch
from
e4bf28c to
b565fb9
Compare
DuodenumL
force-pushed
the
feature/selfmon
branch
from
b565fb9 to
5d45f22
Compare
|
那就合并啦 |
做了以下事情：
!node.Available，不再删除node status。