ETCD/Redis supports "BatchPut" #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
用了这个之后UpdateNodes就不能在ETCD事务层面上保证这个node存在了。 但是其实Calcium里SetNode是加了个锁的，所以不会存在“SetNode过程中这个node突然被删了”的问题，除非有人手动操作。 |
engine/factory/factory.go
Outdated
| @@ -52,12 +53,15 @@ func GetEngineFromCache(ctx context.Context, config types.Config, endpoint, ca, | |||
| RemoveEngineFromCache(endpoint, ca, cert, key) | |||
| return nil | |||
| } | |||
| log.Debugf(ctx, "[GetEngineFromCache] %v success, key %v", endpoint, cacheKey) | |||
There was a problem hiding this comment.
感觉这条日志会暴多 要不在创建 client 的时候打日志 这样可以反过来知道被 cache 了
| return client | ||
| } | ||
|
|
||
| // RemoveEngineFromCache . | ||
| func RemoveEngineFromCache(endpoint, ca, cert, key string) { | ||
| engineCache.Delete(getEngineCacheKey(endpoint, ca, cert, key)) | ||
| cacheKey := getEngineCacheKey(endpoint, ca, cert, key) | ||
| log.Debugf(context.TODO(), "[RemoveEngineFromCache] remove %v, key %v", endpoint, cacheKey) |
There was a problem hiding this comment.
cache 发生变化的时候可以有日志 因为不会很多
There was a problem hiding this comment.
那这里不打debug，打info？
There was a problem hiding this comment.
不是业务日志 还是 debug 算了 反而我们都设置的 debug 级别
DuodenumL
force-pushed
the
feature/endpoint
branch
2 times, most recently
from
4cbfbf4 to
c3c6b81
Compare
DuodenumL
force-pushed
the
feature/endpoint
branch
from
c3c6b81 to
7317f92
Compare
jschwinger233
approved these changes
Dec 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前store/meta/meta.go中的KV有BatchCreate / BatchUpdate，但是没有能支持upsert操作的方法，这在一些情况下可能会造成问题（要求所有key必须全部存在/不存在，否则就报错）。所以这次加了个BatchPut方法，语义就是upsert。