Add stream APIs for PodNodes and PodResource #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jschwinger233
commented
Dec 23, 2021
•
jschwinger233
commented
- 新增了 PodNodesStream 和 PodResourceStream API
- toRPCNode 之前有 IO, node 去 fetch runtime Info, 把这部分放到 cluster 了, 让 rpc/transform 依然保持纯计算无 IO
jschwinger233
force-pushed
the
zc/stream-nodes
branch
from
533dbbc to
7fad652
Compare
jschwinger233
force-pushed
the
zc/stream-nodes
branch
from
fa7142f to
e525e3e
Compare
jschwinger233
changed the title
|
@DuodenumL 求 review |
DuodenumL
reviewed
Dec 29, 2021
| @@ -17,11 +17,15 @@ import ( | |||
| func (c *Calcium) ListNetworks(ctx context.Context, podname string, driver string) ([]*enginetypes.Network, error) { | |||
| logger := log.WithField("Calcium", "ListNetworks").WithField("podname", podname).WithField("driver", driver) | |||
| networks := []*enginetypes.Network{} | |||
| nodes, err := c.ListPodNodes(ctx, podname, nil, false) | |||
| ch, err := c.ListPodNodes(ctx, &types.ListNodesOptions{Podname: podname}) | |||
There was a problem hiding this comment.
是不是应该分别提供返回chan *types.Node和[]*types.Node的两个方法呢？
There was a problem hiding this comment.
没必要吧, cluster 的接口应该正交, 而且内部实现也是流式的, 多个 goroutine 并发去取
There was a problem hiding this comment.
等泛型可用了加一个 ChanToSlice 的泛型函数就好了
DuodenumL
reviewed
Dec 29, 2021
types/node.go
Outdated
| @@ -56,6 +55,7 @@ func (n NodeMeta) DeepCopy() (nn NodeMeta, err error) { | |||
| // Node store node info | |||
| type Node struct { | |||
| NodeMeta | |||
| NodeInfo string | |||
There was a problem hiding this comment.
这个如果不需要存到ETCD里，要不要标上json:"-"
jschwinger233
force-pushed
the
zc/stream-nodes
branch
from
e525e3e to
4d32584
Compare
|
那就这样吧先 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.