[SPPSP-2925] add timeout to ListPodNodes #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
发现我本地的protoc-gen-go是上古版本，生成的pb文件里还是"github.com/golang/protobuf"这个已经过期了的库，赶紧更新了下本地环境。奇怪的是看了下我之前的commit |
rpc/gen/core.proto
Outdated
| @@ -338,6 +338,7 @@ message ListNodesOptions { | |||
| string podname = 1; | |||
| bool all = 2; | |||
| map<string, string> labels = 3; | |||
| int32 timeout = 4; | |||
DuodenumL
force-pushed
the
feature/list-node
branch
from
e7b6531 to
3a5244f
Compare
jschwinger233
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
给ListPodNodes加了个timeout参数，默认是10s。