New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache runtime client in engine/factory module #492

Merged

CMGS merged 1 commit into projecteru2:master from jschwinger233:zc/fix-endpoint

Oct 20, 2021

Member

jschwinger233 commented Oct 19, 2021 •

edited

Loading

原来的 cache 逻辑在 store 实现里, 导致 redis / etcd store 都要重复实现, 给移到 engine/factory 模块下, 这样就 DIY 了
cache key 从 nodename 改成 endpoint, 这样如果更新了 node endpoint url 不会被脏数据污染
cached client 连接中断后也会自动重连, 毕竟智能 client...

又减少代码了, 好耶.


          cache runtime client in engine/factory module

f719e55

jschwinger233 force-pushed the zc/fix-endpoint branch from 6ad1b25 to f719e55 Compare

October 19, 2021 08:51

jschwinger233 changed the title ~~[WIP] Cache runtime client in engine/factory module~~ Cache runtime client in engine/factory module

jschwinger233 requested a review from tonicmuroq

October 19, 2021 08:53

CMGS merged commit fbb668c into projecteru2:master

jschwinger233 mentioned this pull request

New endpoints won't take effects until restarting eru-core #475

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet