Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPVR-60][SPVR-15] implement exitCode #477

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[SPVR-60][SPVR-15] implement exitCode #477

merged 1 commit into from
Oct 8, 2021

Conversation

Aceralon
Copy link
Contributor

@Aceralon Aceralon commented Sep 20, 2021 •
edited
Loading

@Aceralon Aceralon changed the title [WIP] implement exitCode [WIP][SPVR-60][SPVR-15] implement exitCode Sep 21, 2021
@Aceralon Aceralon force-pushed the exit_code branch 3 times, most recently from e059a89 to 0bbb21e Compare September 27, 2021 07:45
@Aceralon Aceralon changed the title [WIP][SPVR-60][SPVR-15] implement exitCode [SPVR-60][SPVR-15] implement exitCode Sep 27, 2021
@Aceralon Aceralon marked this pull request as ready for review September 27, 2021 07:51
@anrs anrs requested a review from jschwinger233 September 27, 2021 08:00
@Aceralon Aceralon changed the title [SPVR-60][SPVR-15] implement exitCode [WIP][SPVR-60][SPVR-15] implement exitCode Sep 28, 2021
@CMGS
Copy link
Contributor

CMGS commented Oct 7, 2021

WIP ?

@Aceralon
Copy link
Contributor Author

Aceralon commented Oct 7, 2021 •
edited
Loading

WIP ?

ready.

@Aceralon Aceralon force-pushed the exit_code branch 2 times, most recently from 3a27d47 to b54686e Compare October 7, 2021 07:26
@Aceralon Aceralon changed the title [WIP][SPVR-60][SPVR-15] implement exitCode [SPVR-60][SPVR-15] implement exitCode Oct 7, 2021
anrs
anrs reviewed Oct 7, 2021
View reviewed changes
engine/engine.go Show resolved Hide resolved
@anrs
Copy link
Contributor

anrs commented Oct 7, 2021

LGTM, maybe @jschwinger23 can take a look

@anrs anrs merged commit 503d397 into projecteru2:master Oct 8, 2021
@3swu 3swu mentioned this pull request Mar 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrs anrs anrs left review comments

@jschwinger233 jschwinger233 Awaiting requested review from jschwinger233

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aceralon @CMGS @anrs