Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node via set node #457

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

nyanpassu
Copy link
Contributor

This PR introduce a feature to enable modify a node endpoint via SetNode rpc method.

What I do and how I archived the goal:

  1. the grpc protocol is updated, a string field of endpoint is added to the message SetNodeOptions, so as to carry value of new endpoint
  2. the transform from pb.SetNodeOptions to types.SetNodeOptions is modified to enable passing value of new endpoint
  3. the method of calcium is modified to distinguish whether or not to update endpoint, if the value of SetNodeOptions.Endpoint is "" the current endpoint value of node is kept, or else the value of node endpoint is set to the new value pass in by SetNodeOptions.Endpoint
  4. unit test is updated to ensure our goal

@nyanpassu nyanpassu changed the title [WIP] Update node via set node Update node via set node Jul 14, 2021
@CMGS CMGS merged commit 9b11ca9 into projecteru2:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants