Resolve potential deadlocks #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jschwinger233
commented
Jun 22, 2021
jschwinger233
commented
- 上多锁前给锁排序
- 如果出现 withNodesLocked + withWorkloadsLocked, 保证先锁节点再锁 workloads
- 解锁时候逆序解锁
jschwinger233
force-pushed
the
zc/deadlock
branch
from
983b729 to
9e24bc2
Compare
CMGS
reviewed
Jun 22, 2021
cluster/calcium/lock.go
Outdated
| // force unlock | ||
| if err := c.doUnlock(ctx, lock, n); err != nil { | ||
| log.Errorf(ctx, "[doUnlockAll] Unlock failed %v", err) | ||
| func (c *Calcium) doUnlockAll(ctx context.Context, locks map[string]lock.DistributedLock, order []string) { |
jschwinger233
force-pushed
the
zc/deadlock
branch
from
29ec032 to
a5500b3
Compare
jschwinger233
changed the title
CMGS
reviewed
Jun 22, 2021
cluster/calcium/lock.go
Outdated
| defer func() { c.doUnlockAll(utils.InheritTracingInfo(ctx, context.Background()), locks) }() | ||
| defer func() { | ||
| utils.Reverse(ids) | ||
| c.doUnlockAll(utils.InheritTracingInfo(ctx, context.Background()), locks, ids...) |
CMGS
reviewed
Jun 22, 2021
cluster/calcium/lock.go
Outdated
| defer c.doUnlockAll(utils.InheritTracingInfo(ctx, context.Background()), locks) | ||
| defer func() { | ||
| utils.Reverse(nodenames) | ||
| c.doUnlockAll(utils.InheritTracingInfo(ctx, context.Background()), locks, nodenames...) |
jschwinger233
force-pushed
the
zc/deadlock
branch
from
a5500b3 to
bd34822
Compare
CMGS
reviewed
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.