reduce unnecessary context.Background() #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMGS
force-pushed
the
no_more_background
branch
3 times, most recently
from
c306c8a to
d305750
Compare
tonicmuroq
reviewed
Apr 13, 2021
utils/gopool.go
Outdated
| // there won't be error once we use background ctx | ||
| p.sem.Acquire(context.Background(), 1) // nolint:errcheck | ||
| p.sem.Acquire(ctx, 1) // nolint:errcheck |
There was a problem hiding this comment.
这里用了非 background ctx 就要处理 error 了... 这个函数的类型就开始变得不美好了
There was a problem hiding this comment.
当时使用 background 的考虑是, 如果只是考虑这是 sync.WaitGroup 的强化版本的话, wg 本身也没有提供被 ctx 打断的能力, 所以我就偷懒做了一个等价语义.....
There was a problem hiding this comment.
Acquire acquires the semaphore with a weight of n, blocking until resources are available or ctx is done. On success, returns nil. On failure, returns ctx.Err() and leaves the semaphore unchanged.
If ctx is already done, Acquire may still succeed without blocking.
根据这个描述，其实你不处理 error 也不是不行
There was a problem hiding this comment.
所以实际上你看 ctx 导致失败的话，semaphore 不会变化，ctx 错误忽略就行了，还能有啥错误呢对吧……
CMGS
force-pushed
the
no_more_background
branch
from
d305750 to
7b2d437
Compare
CMGS
force-pushed
the
no_more_background
branch
from
7b2d437 to
22411b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems redis lock should return wrapped context like etcd lock @tonicbupt