Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add err handling, avoid panic #374

Merged
merged 1 commit into from
Mar 31, 2021
Merged

add err handling, avoid panic #374

merged 1 commit into from
Mar 31, 2021

Conversation

EastonLee
Copy link
Contributor

No description provided.

jschwinger233
jschwinger233 approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@jschwinger233 jschwinger233 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I am just about to add this. The panic in qa env is irritating.

@CMGS CMGS merged commit 6e5e014 into projecteru2:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschwinger233 jschwinger233 jschwinger233 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EastonLee @jschwinger233 @CMGS