redis as broker #369
Merged
redis as broker #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonicmuroq
force-pushed
the
redis-broker
branch
from
6c7efb6 to
b5e7120
Compare
|
另外 in memory for unittest 的 redis 不支持 keyspace notification, 就依赖一个服务了, 每次要清空还只能 |
CMGS
reviewed
Mar 29, 2021
| "time" | ||
|
|
||
| "github.com/go-redis/redis/v8" | ||
| "github.com/muroq/redislock" |
There was a problem hiding this comment.
... 要不 fork 到这个 namespace 也可以的, 是因为他把 ttl 捆绑到一起了, 我觉得这个行为非常诡异, 所以 fork 了修改了
There was a problem hiding this comment.
可以考虑放 github.com/projecteru2/ 下面
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis 基本不能跟 etcd 比啊, 没有隔离性, 事务跟没有一样, 但是好像外围的操作一般都会加个锁, 似乎也是可以的...
另外就是自己去 pubsub 的话, 没办法处理 key expired 的情况, 所以只好开启 keyspace notification, 用 list 是不可以的, 用了 core 就没办法 scale out 了