Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refines DAL from DAO #330

Merged
merged 2 commits into from
Feb 1, 2021
Merged

refines DAL from DAO #330

merged 2 commits into from
Feb 1, 2021

Conversation

anrs
Copy link
Contributor

@anrs anrs commented Jan 28, 2021

No description provided.

@anrs anrs changed the title WIP: refines DAL from DAO refines DAL from DAO Feb 1, 2021
CMGS
CMGS reviewed Feb 1, 2021
View reviewed changes
store/etcdv3/workload.go
if ttl != 0 {
if lease, err = cliv3.Grant(ctx, ttl); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得这里要重写

@CMGS CMGS merged commit 14b8e7c into projecteru2:master Feb 1, 2021
@anrs anrs deleted the dal branch February 17, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMGS CMGS CMGS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anrs @CMGS