Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demultiplex exec output into stdout / stderr #327

Merged
merged 6 commits into from
Jan 28, 2021
Merged

demultiplex exec output into stdout / stderr #327

merged 6 commits into from
Jan 28, 2021

Conversation

jschwinger233
Copy link
Member

No description provided.

CMGS
CMGS reviewed Jan 26, 2021
View reviewed changes
cluster/calcium/execute.go Outdated
}

streamWg := sync.WaitGroup{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直觉上来说这个 streamWg 是没必要的

@jschwinger233 jschwinger233 changed the title [WIP] demultiplex exec output into stdout / stderr demultiplex exec output into stdout / stderr Jan 27, 2021
@CMGS CMGS merged commit 8afc19a into projecteru2:master Jan 28, 2021
@CMGS CMGS mentioned this pull request Jan 28, 2021
Merged
@CMGS
Copy link
Contributor

CMGS commented Jan 28, 2021

另外 ok github.com/projecteru2/core/cluster/calcium 1.086s coverage: 89.7% of statements 覆盖率下降了 0.1%

@CMGS CMGS mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CMGS CMGS CMGS left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jschwinger233 @CMGS